Fixed little endian (and scaling/offset) #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed little endian handling Fixed offset / scaling handling
geohot
requested changes
Mar 1, 2017
common/dbc.py
Outdated
| @@ -160,11 +163,17 @@ def decode(self, x, arr=None, debug=False): | |||
| # big or little endian? | |||
| # see http://vi-firmware.openxcplatform.com/en/master/config/bit-numbering.html | |||
| if s[3] is False: | |||
| endianness = "big" | |||
There was a problem hiding this comment.
This variable looks unused
| ival = (ival + s[6])*s[5] | ||
| if debug: | ||
| print "%40s %2d %2d %7.2f %s" % (s[0], s[1], s[2], ival, s[-1]) | ||
| ival = (ival * s[5]) + s[6] |
There was a problem hiding this comment.
Wow, how did this work before?
There was a problem hiding this comment.
It worked only because almost all the signals in the Acura dbc had their offsets at zero!
Removed unused debug strings
|
Removed the unused debug comments. Should be good now! |
geohot
pushed a commit
that referenced
this pull request
Jan 19, 2018
icmma
added a commit
to priuscom/openpilot
that referenced
this pull request
Jan 28, 2019
icmma
added a commit
to priuscom/openpilot
that referenced
this pull request
Jan 28, 2019
Merge pull request commaai#65 from commaai/devel
avolmensky
pushed a commit
to avolmensky/openpilot
that referenced
this pull request
Jun 10, 2019
* Add Honda Clarity Hybrid * Update brake length and factor
avolmensky
pushed a commit
to avolmensky/openpilot
that referenced
this pull request
Jun 30, 2019
updated linux driver docs
sjkoon
pushed a commit
to sjkoon/openpilot
that referenced
this pull request
Mar 13, 2020
door detection.
jnewb1
added a commit
that referenced
this pull request
Dec 28, 2023
* update labeler * update labeler * update labeler * Update labeler (#63) * update labeler * update labeler * update labeler * fix that * Update labeler (#65) * update labeler * update labeler * update labeler * fix that * and that * Update labeler (#66) * update labeler * update labeler * update labeler * fix that * and that * fix that
garrettpall
pushed a commit
to garrettpall/openpilot
that referenced
this pull request
Jan 30, 2024
Make building easier
garrettpall
pushed a commit
to garrettpall/openpilot
that referenced
this pull request
Feb 1, 2024
Make building easier
carleeno
pushed a commit
to carleeno/openpilot
that referenced
this pull request
Aug 2, 2024
* MADS: better doorOpen event logic * unnecessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed little endian handling
Fixed offset / scaling handling
Works on my Tesla DBC (that has mixed little & big endian). Please test.